Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625917

[tip:x86/asm] x86/unwind: Remove unused 'sp' parameter in unwind_dump()

Show all headers | View raw

Commit-ID:  aa4f853461aab5f526a312bf418091a95626632b
Gitweb:     http://git.kernel.org/tip/aa4f853461aab5f526a312bf418091a95626632b
Author:     Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Tue, 18 Apr 2017 08:12:58 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 19 Apr 2017 09:59:47 +0200

x86/unwind: Remove unused 'sp' parameter in unwind_dump()

The 'sp' parameter to unwind_dump() is unused.  Remove it.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/08cb36b004629f6bbcf44c267ae4a609242ebd0b.1492520933.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/unwind_frame.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/unwind_frame.c b/arch/x86/kernel/unwind_frame.c
index 5d26374..bda82df 100644
--- a/arch/x86/kernel/unwind_frame.c
+++ b/arch/x86/kernel/unwind_frame.c
@@ -25,11 +25,11 @@
 	val;						\
 })
 
-static void unwind_dump(struct unwind_state *state, unsigned long *sp)
+static void unwind_dump(struct unwind_state *state)
 {
 	static bool dumped_before = false;
 	bool prev_zero, zero = false;
-	unsigned long word;
+	unsigned long word, *sp;
 
 	if (dumped_before)
 		return;
@@ -287,13 +287,13 @@ bad_address:
 			"WARNING: kernel stack regs at %p in %s:%d has bad 'bp' value %p\n",
 			state->regs, state->task->comm,
 			state->task->pid, next_bp);
-		unwind_dump(state, (unsigned long *)state->regs);
+		unwind_dump(state);
 	} else {
 		printk_deferred_once(KERN_WARNING
 			"WARNING: kernel stack frame pointer at %p in %s:%d has bad value %p\n",
 			state->bp, state->task->comm,
 			state->task->pid, next_bp);
-		unwind_dump(state, state->bp);
+		unwind_dump(state);
 	}
 the_end:
 	state->stack_info.type = STACK_TYPE_UNKNOWN;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] x86/unwind: unwind_dump() cleanups Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-18 15:20 +0200
  [PATCH 1/3] x86/unwind: properly zero-pad 32-bit values in unwind_dump() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-18 15:20 +0200
    [tip:x86/asm] x86/unwind: Properly zero-pad 32-bit values in  unwind_dump() tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-04-19 10:20 +0200
  [PATCH 3/3] x86/unwind: remove unused 'sp' argument in unwind_dump() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-18 15:20 +0200
    [tip:x86/asm] x86/unwind: Remove unused 'sp' parameter in  unwind_dump() tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-04-19 10:20 +0200
  [PATCH 2/3] x86/unwind: prepend hex mask value with '0x' in unwind_dump() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-18 15:20 +0200
    [tip:x86/asm] x86/unwind: Prepend hex mask value with '0x' in  unwind_dump() tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-04-19 10:20 +0200

csiph-web