[PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe()
Date	2017-04-19 09:30 +0200
Message-ID	<txSdQ-sj-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 19 Apr 2017 09:12:43 +0200

Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "devm_kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/bus/arm-ccn.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
index 4d6a2b7e4d3f..6375bda0b2a1 100644
--- a/drivers/bus/arm-ccn.c
+++ b/drivers/bus/arm-ccn.c
@@ -1520,10 +1520,10 @@ static int arm_ccn_probe(struct platform_device *pdev)
 	if (err)
 		return err;
 
-	ccn->node = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_nodes,
-		GFP_KERNEL);
-	ccn->xp = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_xps,
-		GFP_KERNEL);
+	ccn->node = devm_kcalloc(ccn->dev, ccn->num_nodes, sizeof(*ccn->node),
+				 GFP_KERNEL);
+	ccn->xp = devm_kcalloc(ccn->dev, ccn->num_xps, sizeof(*ccn->node),
+			       GFP_KERNEL);
 	if (!ccn->node || !ccn->xp)
 		return -ENOMEM;
 
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 09:30 +0200
  Re: [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe() Mark Rutland <mark.rutland@arm.com> - 2017-04-19 10:30 +0200
  Re: [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe() Pawel Moll <pawel.moll@arm.com> - 2017-04-19 15:10 +0200

csiph-web