Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625908

Re: [PATCH V4] x86: call smp vmxoff in smp stop

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4] x86: call smp vmxoff in smp stop
Date 2017-04-19 10:10 +0200
Message-ID <txSQy-YG-31@gated-at.bofh.it> (permalink)
References <sVQPL-3lt-11@gated-at.bofh.it> <sW5lL-4mv-1@gated-at.bofh.it> <sZlDH-8g9-1@gated-at.bofh.it> <t0WUy-3AT-19@gated-at.bofh.it> <txBwl-6Is-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

* Paolo Bonzini <pbonzini@redhat.com> wrote:

> Ingo, can you put this in tip?
> 
> Thanks,
> 
> Paolo
> 
> On 18/01/2017 12:32, Xishi Qiu wrote:
> > From: Tiantian Feng <fengtiantian@huawei.com>
> > 
> > We need to disable VMX on all CPUs before stop cpu when OS panic,
> > otherwisewe risk hanging up the machine, because the CPU ignore INIT
> > signals when VMX is enabled. In kernel mainline this issue existence.

Yes, but the changelog is atrcious:

 - title should describe the purpose, not the implementation

 - CPU is spelled 'CPU' once, then 'cpu' _in the same sentence_!

 - typos

 - spelling

 - the last sentence doesn't even parse ...

Still it's already at V4 and comes with two signoffs and what amounts to a 
maintainer Ack??

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V4] x86: call smp vmxoff in smp stop Paolo Bonzini <pbonzini@redhat.com> - 2017-04-18 15:40 +0200
  Re: [PATCH V4] x86: call smp vmxoff in smp stop Ingo Molnar <mingo@kernel.org> - 2017-04-19 10:10 +0200
    Re: [PATCH V4] x86: call smp vmxoff in smp stop Paolo Bonzini <pbonzini@redhat.com> - 2017-04-19 10:30 +0200
      Re: [PATCH V4] x86: call smp vmxoff in smp stop Ingo Molnar <mingo@kernel.org> - 2017-04-19 12:00 +0200

csiph-web