Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp()

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp()
Date	2017-04-19 08:40 +0200
Message-ID	<txRrs-8mT-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <txyI9-54q-1@gated-at.bofh.it> <txB3k-6zp-15@gated-at.bofh.it> <txEuf-8r4-45@gated-at.bofh.it> <txHV8-29d-21@gated-at.bofh.it> <txIo9-2iz-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 18, 2017 at 10:50:43PM +0200, Thomas Gleixner wrote:
> On Tue, 18 Apr 2017, Peter Zijlstra wrote:
> > On Tue, Apr 18, 2017 at 12:46:29PM -0400, Steven Rostedt wrote:
> > > On Tue, 18 Apr 2017 15:03:50 +0200
> > > Peter Zijlstra <peterz@infradead.org> wrote:
> > > 
> > > > +++ b/kernel/padata.c
> > > > @@ -1008,11 +1008,10 @@ static struct padata_instance *padata_al
> > > >   *                         parallel workers.
> > > >   *
> > > >   * @wq: workqueue to use for the allocated padata instance
> > > > - *
> > > > - * Must be called from a get_online_cpus() protected region
> > > 
> > > Find the comment redundant?
> > 
> > Once there's code that enforces it? Yes. Nobody reads comments
> > ;-)
> 
> Nobody enables lockdep either .....

In the grand scheme of things, true. But there are more people running
with lockdep enabled than there are people writing code, of which there
are more than people reading relevant comments while writing code.
Therefore having the lockdep annotation is two orders better than a
comment ;-)

Also, I would argue that an "assert" at the start of a function is a
fairly readable 'comment' all by itself.

In any case, I don't care too much. But I typically remove such comments
when I stick a lockdep_assert_held() in.

Thread

[PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Peter Zijlstra <peterz@infradead.org> - 2017-04-18 12:40 +0200
  Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Peter Zijlstra <peterz@infradead.org> - 2017-04-18 15:10 +0200
    Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Steven Rostedt <rostedt@goodmis.org> - 2017-04-18 18:50 +0200
      Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Peter Zijlstra <peterz@infradead.org> - 2017-04-18 22:30 +0200
        Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Thomas Gleixner <tglx@linutronix.de> - 2017-04-18 23:00 +0200
          Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Peter Zijlstra <peterz@infradead.org> - 2017-04-19 08:40 +0200
            Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Thomas Gleixner <tglx@linutronix.de> - 2017-04-19 11:10 +0200
              Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Steven Rostedt <rostedt@goodmis.org> - 2017-04-19 14:50 +0200
                Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Peter Zijlstra <peterz@infradead.org> - 2017-04-19 16:10 +0200
                Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Steven Rostedt <rostedt@goodmis.org> - 2017-04-19 16:30 +0200
  [tip:smp/hotplug] jump_label: Provide  static_key_slow_inc_cpuslocked() "tip-bot for Peter Zijlstra (Intel)" <tipbot@zytor.com> - 2017-04-20 13:40 +0200

csiph-web