Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625801

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

Show all headers | View raw

On Tue, Apr 18, 2017 at 11:19 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> On Tue, Apr 18, 2017 at 9:01 PM, Michel Dänzer <michel@daenzer.net> wrote:
>> On 18/04/17 07:14 PM, Gerd Hoffmann wrote:
>>>   Hi,
>>>
>>>>> Quite true that this proves nothing. However one should note that
>>>>> fbcon -> fbdev works,
>>>>
>>>> BTW, this supports Gerd's patch, since the KMS fbdev emulation code uses
>>>> e.g. DRM_FORMAT_XRGB8888 for depth/bpp 24/32, and the fbdev API uses
>>>> native endian packed colour values.
>>>
>>> Same is true for DRM_IOCTL_MODE_ADDFB, with depth/bpp 24/32 you'll get
>>> DRM_FORMAT_XRGB8888 (only DRM_IOCTL_MODE_ADDFB2 allows userspace specify
>>> fourcc formats directly).
>>
>> Right, and since all major Xorg drivers use DRM_IOCTL_MODE_ADDFB,
>> they're effectively using DRM_FORMAT_XRGB8888 as native endianness as well.
>
> In the meanwhile, it has been pointed out to me that pre-nv50 display
> code actually doesn't use DRM_FORMAT_* at all -- it uses some helpers
> which end up advertising XR24 / AR24. However from what I can tell,
> that's not a well-reasoned selection. Either way, I'm going to test
> Gerd's patch, hopefully during the week, or weekend at the latest. My
> current suspicion is that it will have no effect on nouveau either
> way. We'll find out.

(And as Michel points out, the patch doesn't actually touch anything,
just comments. I originally thought it changed format -> fourcc
mapping.)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Pekka Paalanen <ppaalanen@gmail.com> - 2017-04-10 17:20 +0200
  Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Ilia Mirkin <imirkin@alum.mit.edu> - 2017-04-10 18:20 +0200
    Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Pekka Paalanen <ppaalanen@gmail.com> - 2017-04-11 09:40 +0200
      Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Gerd Hoffmann <kraxel@redhat.com> - 2017-04-11 13:30 +0200
        Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Pekka Paalanen <ppaalanen@gmail.com> - 2017-04-13 09:50 +0200
      Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Ilia Mirkin <imirkin@alum.mit.edu> - 2017-04-11 16:20 +0200
        Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Ilia Mirkin <imirkin@alum.mit.edu> - 2017-04-17 08:50 +0200
          Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Michel Dänzer <michel@daenzer.net> - 2017-04-18 05:00 +0200
            Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Ilia Mirkin <imirkin@alum.mit.edu> - 2017-04-18 07:10 +0200
              Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Michel Dänzer <michel@daenzer.net> - 2017-04-18 08:00 +0200
                Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Gerd Hoffmann <kraxel@redhat.com> - 2017-04-18 12:20 +0200
                Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Michel Dänzer <michel@daenzer.net> - 2017-04-19 03:10 +0200
                Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Ilia Mirkin <imirkin@alum.mit.edu> - 2017-04-19 05:20 +0200
                Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in  line with reality. Ilia Mirkin <imirkin@alum.mit.edu> - 2017-04-19 05:30 +0200
                Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Pekka Paalanen <ppaalanen@gmail.com> - 2017-04-19 09:20 +0200
                Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Gerd Hoffmann <kraxel@redhat.com> - 2017-04-19 14:40 +0200
  Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Gerd Hoffmann <kraxel@redhat.com> - 2017-04-18 12:10 +0200
    Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Pekka Paalanen <ppaalanen@gmail.com> - 2017-04-18 13:20 +0200
      Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Gerd Hoffmann <kraxel@redhat.com> - 2017-04-18 15:50 +0200
        Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Pekka Paalanen <ppaalanen@gmail.com> - 2017-04-18 16:10 +0200
          Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments  in line with reality. Gerd Hoffmann <kraxel@redhat.com> - 2017-04-18 23:00 +0200

csiph-web