Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE
Date	2017-04-18 23:00 +0200
Message-ID	<txIo9-2iz-5@gated-at.bofh.it> (permalink)
References	<txHV8-29d-5@gated-at.bofh.it> <txHV9-29d-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Markus,

On Tue, Apr 18, 2017 at 01:17:02PM -0700, Markus Mayer wrote:
> From: Markus Mayer <mmayer@broadcom.com>
> 
> This driver allows access to DRAM properties, such as the refresh rate,
> via the Broadcom STB DDR PHY Front End (DPFE). The refresh rate can be
> used as indirect indicator of the DRAM temperature.
> 
> The driver also allows setting of the sampling interval.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
[ ... ]

> +
> +static SENSOR_DEVICE_ATTR(dpfe_info, 0444, show_info, NULL, 1000);
> +static SENSOR_DEVICE_ATTR(dpfe_refresh, 0644, show_refresh, store_refresh,
> +			  1000);
> +static SENSOR_DEVICE_ATTR(dpfe_vendor, 0444, show_vendor, NULL, 1000);
> +static struct attribute *dpfe_attrs[] = {
> +	&sensor_dev_attr_dpfe_info.dev_attr.attr,
> +	&sensor_dev_attr_dpfe_refresh.dev_attr.attr,
> +	&sensor_dev_attr_dpfe_vendor.dev_attr.attr,
> +	NULL
> +};
> +ATTRIBUTE_GROUPS(dpfe);
> +

There is not a single standard hwmon attribute. I don't know how
to classify this driver, and where it should reside, but it is not
a hwmon driver. 

Thanks,
Guenter

Thread

[PATCH 0/2] HWMON driver for Broadcom STB DPFE Markus Mayer <code@mmayer.net> - 2017-04-18 22:30 +0200
  [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors Markus Mayer <code@mmayer.net> - 2017-04-18 22:30 +0200
  [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE Markus Mayer <code@mmayer.net> - 2017-04-18 22:30 +0200
    Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE Guenter Roeck <linux@roeck-us.net> - 2017-04-18 23:00 +0200
      Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 00:40 +0200
        Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE Guenter Roeck <linux@roeck-us.net> - 2017-04-19 00:50 +0200
          Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE Markus Mayer <code@mmayer.net> - 2017-04-19 02:20 +0200
            Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 02:30 +0200

csiph-web