Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32 and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACER && CONFIG_CC_OPTIMIZE_FOR_SIZE

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following combination is not supported: ((compiler missing -mfentry) \|\| (CONFIG_X86_32 and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACER && CONFIG_CC_OPTIMIZE_FOR_SIZE
Date	2017-04-18 22:30 +0200
Message-ID	<txHV8-29d-3@gated-at.bofh.it> (permalink)
References	<twHaN-5Jn-1@gated-at.bofh.it> <txf2N-1br-3@gated-at.bofh.it> <txGw2-1bd-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 18, 2017 at 11:52:41AM -0700, Andi Kleen wrote:
> Josh Poimboeuf <jpoimboe@redhat.com> writes:
> >
> > The error is working as designed.  gcc < 4.6.0 doesn't have -mfentry, so
> > it fails the above check on x86.  Can you add a skip rule?  It should
> > skip building the following case:
> >
> >   x86 && ((gcc < 4.6.0) || (CONFIG_X86_32 and !CONFIG_DYNAMIC_FTRACE))
> > && CONFIG_FUNCTION_GRAPH_TRACER && CONFIG_CC_OPTIMIZE_FOR_SIZE
> 
> This will also break everyone's randconfig builds. The better way
> would be to check this in the Makefile and disable one of the options

I don't know how to disable a config option from the Makefile like that.
Any ideas?

BTW, I think it will only break randconfigs for old versions of gcc,
before 4.6.0.  The error message isn't quite right.  I just noticed the
FUNCTION_GRAPH_TRACER config has:

  depends on !X86_32 || !CC_OPTIMIZE_FOR_SIZE

which means that X86_32 and CC_OPTIMIZE_FOR_SIZE can never be set with
FUNCTION_GRAPH_TRACER.  So the error message could be simplified to:

  #error The following combination is not supported: (compiler missing -mfentry) && CONFIG_FUNCTION_GRAPH_TRACER && CONFIG_CC_OPTIMIZE_FOR_SIZE

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

arch/x86//kernel/ftrace.c:35:3: error: #error The following  combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32  and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACER &&  CONFIG_CC_OPTIMIZE_FOR_SIZE kbuild test robot <fengguang.wu@intel.com> - 2017-04-16 03:30 +0200
  Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following  combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32  and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACER &&  CONFIG_CC_OPTIMIZE_FOR_SIZE Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-17 15:40 +0200
    Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32 and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACER && CONFIG_CC_OPTIMIZE_FOR_SIZE Andi Kleen <andi@firstfloor.org> - 2017-04-18 21:00 +0200
      Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following  combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32  and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACER &&  CONFIG_CC_OPTIMIZE_FOR_SIZE Andi Kleen <andi@firstfloor.org> - 2017-04-18 22:30 +0200
        [PATCH] x86/build: convert function graph '-Os' error to warning Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-18 23:50 +0200
          [tip:x86/urgent] x86/build: convert function graph '-Os' error to  warning tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-04-19 10:20 +0200
      Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following  combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32  and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACER &&  CONFIG_CC_OPTIMIZE_FOR_SIZE Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-18 22:30 +0200

csiph-web