Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1625504
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver |
| Date | 2017-04-18 20:00 +0200 |
| Message-ID | <txFzY-AR-7@gated-at.bofh.it> (permalink) |
| References | <twWMx-6S7-5@gated-at.bofh.it> <twWMx-6S7-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Sun, Apr 16, 2017 at 08:08:01PM +0200, Marek Vasut wrote:
This looks good, a couple of minor things though:
> +static int bd9571mwv_regulator_is_enabled(struct regulator_dev *reg)
> +{
> + /* Always enabled. */
> + return 1;
> +}
This should be the default implementation, no need to open code it.
> +int bd9571mwv_set_voltage_sel_regmap(struct regulator_dev *rdev,
> + unsigned int sel)
> +{
> + return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
> + rdev->desc->vsel_mask, sel);
> +}
regulator_set_voltage_sel_regmap().
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver Marek Vasut <marek.vasut@gmail.com> - 2017-04-16 20:10 +0200
Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver Mark Brown <broonie@kernel.org> - 2017-04-18 20:00 +0200
Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver Marek Vasut <marek.vasut@gmail.com> - 2017-04-18 21:10 +0200
csiph-web