Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625431

Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC

From Stephen Warren <swarren@wwwdotorg.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC
Date 2017-04-18 18:30 +0200
Message-ID <txEaR-8kF-5@gated-at.bofh.it> (permalink)
References <txD57-7Jd-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 04/18/2017 09:11 AM, Paul Kocialkowski wrote:
> This selects the tegra30 i2s and ahub controllers for the tegra124 SoC.
> These are needed when building without ARCH_TEGRA_3x_SOC set.

> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index efbe8d4c019e..bcd18d2cf7a7 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF
>
>  config SND_SOC_TEGRA30_AHUB
>  	tristate
> -	depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC
> +	depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC || ARCH_TEGRA_124_SOC)

Is this really a compile-time dependency? If so, don't we need to add 
T210 and T186 entries into that || condition too, since we could be 
building a kernel with just T210/T186 support and no T124 support?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC Paul Kocialkowski <contact@paulk.fr> - 2017-04-18 17:20 +0200
  Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for  tegra124 SoC Stephen Warren <swarren@wwwdotorg.org> - 2017-04-18 18:30 +0200
    Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for  tegra124 SoC Paul Kocialkowski <contact@paulk.fr> - 2017-04-18 18:40 +0200
      Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for  tegra124 SoC Stephen Warren <swarren@wwwdotorg.org> - 2017-04-20 00:10 +0200
        Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for  tegra124 SoC Paul Kocialkowski <contact@paulk.fr> - 2017-04-24 17:10 +0200
          Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for  tegra124 SoC Stephen Warren <swarren@wwwdotorg.org> - 2017-04-24 17:40 +0200
            Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for  tegra124 SoC Paul Kocialkowski <contact@paulk.fr> - 2017-04-24 20:50 +0200

csiph-web