Re: [PATCH 5/7] regulator: arizona-ldo1: Move pdata into a separate structure

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/7] regulator: arizona-ldo1: Move pdata into a separate structure
Date	Tue, 18 Apr 2017 17:00:01 +0200
Message-ID	<txCLL-7nt-3@gated-at.bofh.it> (permalink)
References	<txyRP-57S-5@gated-at.bofh.it> <txyRP-57S-11@gated-at.bofh.it>
X-Gm-Message-State	AN3rC/6er1/oYzWgC4wtOaBSHWus8OEabsloflhrO/+y9HN/yr8YOvQF D5Oh6t7pZjFYw3DR2KcAmfHCA19Fkg==
X-Received	by 10.107.10.103 with SMTP id u100mr13492179ioi.76.1492527162974; Tue, 18 Apr 2017 07:52:42 -0700 (PDT)
MIME-Version	1.0
X-Gmail-Original-Message-ID	<CAJKOXPd81C9FOtXVcpwAd=-rWNS0jQK+Qt8NqokmppP8HUKLCQ@mail.gmail.com>
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	broonie@kernel.org, lee.jones@linaro.org, kgene@kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org
X-Original-Date	Tue, 18 Apr 2017 16:52:42 +0200
X-Original-Message-ID	<CAJKOXPd81C9FOtXVcpwAd=-rWNS0jQK+Qt8NqokmppP8HUKLCQ@mail.gmail.com>
X-Original-References	<1492512234-19210-1-git-send-email-rf@opensource.wolfsonmicro.com> <1492512234-19210-7-git-send-email-rf@opensource.wolfsonmicro.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1625376

Show key headers only | View raw

On Tue, Apr 18, 2017 at 12:43 PM, Richard Fitzgerald
<rf@opensource.wolfsonmicro.com> wrote:
> In preparation for sharing this driver with Madera, move the pdata
> for the LDO1 regulator out of struct arizona_pdata into a dedicated
> pdata struct for this driver. As a result the code in
> arizona_ldo1_of_get_pdata() can be made independent of struct arizona.
>
> This patch also updates the definition of struct arizona_pdata and
> the use of this pdata in mach-crag6410-module.c
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
>  arch/arm/mach-s3c64xx/mach-crag6410-module.c |  8 ++++--
>  drivers/regulator/arizona-ldo1.c             | 39 +++++++++++++++-------------
>  include/linux/mfd/arizona/pdata.h            |  4 +--
>  include/linux/regulator/arizona-ldo1.h       | 24 +++++++++++++++++
>  4 files changed, 53 insertions(+), 22 deletions(-)
>  create mode 100644 include/linux/regulator/arizona-ldo1.h
>
> diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> index ccc3ab8..ea5f216 100644
> --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> @@ -209,7 +209,9 @@
>  };
>
>  static struct arizona_pdata wm5102_reva_pdata = {
> -       .ldoena = S3C64XX_GPN(7),
> +       .ldo1 = {
> +               .ldoena = S3C64XX_GPN(7),
> +       },
>         .gpio_base = CODEC_GPIO_BASE,
>         .irq_flags = IRQF_TRIGGER_HIGH,
>         .micd_pol_gpio = CODEC_GPIO_BASE + 4,
> @@ -239,7 +241,9 @@
>  };
>
>  static struct arizona_pdata wm5102_pdata = {
> -       .ldoena = S3C64XX_GPN(7),
> +       .ldo1 = {
> +               .ldoena = S3C64XX_GPN(7),
> +       },
>         .gpio_base = CODEC_GPIO_BASE,
>         .irq_flags = IRQF_TRIGGER_HIGH,
>         .micd_pol_gpio = CODEC_GPIO_BASE + 2,

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Thread

[PATCH 5/7] regulator: arizona-ldo1: Move pdata into a separate structure Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2017-04-18 12:50 +0200
  Re: [PATCH 5/7] regulator: arizona-ldo1: Move pdata into a separate structure Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-18 17:00 +0200
  Re: [PATCH 5/7] regulator: arizona-ldo1: Move pdata into a separate  structure Lee Jones <lee.jones@linaro.org> - 2017-04-24 14:00 +0200

csiph-web