Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries
Date	2017-04-18 16:20 +0200
Message-ID	<txC94-7aw-13@gated-at.bofh.it> (permalink)
References	<tuDO2-7gt-25@gated-at.bofh.it> <txi0G-2Z0-17@gated-at.bofh.it> <txtIt-29C-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, April 18, 2017 10:45:26 AM Viresh Kumar wrote:
> On 17-04-17, 18:40, Rafael J. Wysocki wrote:
> > On Monday, April 17, 2017 06:35:25 PM Rafael J. Wysocki wrote:
> > > On Monday, April 17, 2017 11:07:51 AM Masahiro Yamada wrote:
> > > > 2017-04-15 7:47 GMT+09:00 Rafael J. Wysocki <rjw@rjwysocki.net>:
> > > > > On Monday, April 10, 2017 02:51:35 PM Viresh Kumar wrote:
> > > > >> Compiling the DT file with W=1, DTC warns like follows:
> > > > >>
> > > > >> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> > > > >> unit name, but no reg property
> > > > >>
> > > > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a
> > > > >> "reg" property.
> > > > >>
> > > > >> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > >> Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > > >> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> > > > >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > > >> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> (sunxi)
> > > > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> > > > >> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > >
> > > > > OK, so any ACKs from the DT side?  Rob?
> > > > >
> > > > > Thanks,
> > > > > Rafael
> > > > 
> > > > 
> > > > 
> > > > I see Rob's Acked-by.
> > > > 
> > > > https://lkml.org/lkml/2017/4/13/648
> > > 
> > > Indeed.  Thanks!
> > 
> > But it doesn't apply on top of -rc7 for me, so I guess there is new 4.12-candidate
> > material in the DTS tree that conflicts with this, in which case it is better to route
> > it through the DTS tree IMO.
> 
> Yes a minor conflict. I have sent the rebased version now, see if you
> want to apply it directly or want arm-soc guys to do it.

I'm going to apply the rebased one.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-15 01:00 +0200
  Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-17 04:10 +0200
    Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-17 18:50 +0200
      Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-17 18:50 +0200
        Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-18 07:20 +0200
          Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-18 16:20 +0200

csiph-web