Re: [RFC 3/3] sched/topology: Different sched groups must not have the same balance cpu

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 3/3] sched/topology: Different sched groups must not have the same balance cpu
Date	2017-04-18 14:40 +0200
Message-ID	<txAAh-6aM-1@gated-at.bofh.it> (permalink)
References	<tvNrX-3KR-5@gated-at.bofh.it> <tvNrY-3KR-29@gated-at.bofh.it> <twcA2-3pr-17@gated-at.bofh.it> <txgUV-2mc-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 17, 2017 at 12:34:05PM -0300, Lauro Venancio wrote:
> This patch ensures tree things:
> 
> 1) different instances of the same group share the same
> sched_group_capacity instance.
> 
> 2) instances of different groups don't share the same
> sched_group_capacity instance.
> 
> 3) the group balance cpu must be one of the cpus where the group is
> installed.
> 
> 
> I am rebasing this patch on top of your patches.

Well, I would rather have 3 patches, each with a comprehensible
changelog.

I had already rebased the patch (trivial) so that's not the problem.
Explaining what and why it does things is.

And as per the usual rules, if it does 3 things it should be 3 patches.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC 0/3] sched/topology: fix sched groups on NUMA machines with mesh topology Lauro Ramos Venancio <lvenanci@redhat.com> - 2017-04-13 16:00 +0200
  [RFC 1/3] sched/topology: Refactor function build_overlap_sched_groups() Lauro Ramos Venancio <lvenanci@redhat.com> - 2017-04-13 16:00 +0200
    Re: [RFC 1/3] sched/topology: Refactor function  build_overlap_sched_groups() Rik van Riel <riel@redhat.com> - 2017-04-13 17:00 +0200
  [RFC 3/3] sched/topology: Different sched groups must not have the same balance cpu Lauro Ramos Venancio <lvenanci@redhat.com> - 2017-04-13 16:00 +0200
    Re: [RFC 3/3] sched/topology: Different sched groups must not have  the same balance cpu Rik van Riel <riel@redhat.com> - 2017-04-13 17:30 +0200
    Re: [RFC 3/3] sched/topology: Different sched groups must not have  the same balance cpu Peter Zijlstra <peterz@infradead.org> - 2017-04-14 18:50 +0200
      Re: [RFC 3/3] sched/topology: Different sched groups must not have  the same balance cpu Lauro Venancio <lvenanci@redhat.com> - 2017-04-17 17:40 +0200
        Re: [RFC 3/3] sched/topology: Different sched groups must not have  the same balance cpu Peter Zijlstra <peterz@infradead.org> - 2017-04-18 14:40 +0200

csiph-web