Re: [PATCH v2 11/11] arm64: allwinner: a64: enable Wi-Fi for Pine64

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 11/11] arm64: allwinner: a64: enable Wi-Fi for Pine64
Date	Mon, 17 Apr 2017 10:00:02 +0200
Message-ID	<tx9JM-6so-3@gated-at.bofh.it> (permalink)
References	<ttGXE-2Kw-5@gated-at.bofh.it> <ttGXF-2Kw-53@gated-at.bofh.it> <twcJI-3tb-19@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eaipdegxr3teyztl"
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	85
Organization	linux.* mail to news gateway
X-Original-Cc	Icenowy Zheng <icenowy@aosc.io>, Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Mon, 17 Apr 2017 09:59:21 +0200
X-Original-Message-ID	<20170417075921.vrjchymctxidtp7l@lukather>
X-Original-References	<20170407183441.58750-1-icenowy@aosc.io> <20170407183441.58750-12-icenowy@aosc.io> <e51897d2-aa9d-1f4b-3fe0-e88246a9e438@suse.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1624588

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 14, 2017 at 06:56:16PM +0200, Andreas Färber wrote:
> > one provides I/O voltage).
> > 
> > Add device node for it.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > index 7da074f95065..9d90bb32aa87 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > @@ -64,6 +64,11 @@
> >  		regulator-min-microvolt = <3300000>;
> >  		regulator-max-microvolt = <3300000>;
> >  	};
> > +
> > +	wifi_pwrseq: wifi_pwrseq {
> > +		compatible = "mmc-pwrseq-simple";
> > +		reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
> > +	};
> >  };
> >  
> >  &ehci1 {
> > @@ -91,6 +96,17 @@
> >  	status = "okay";
> >  };
> >  
> > +&mmc1 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&mmc1_pins>;
> > +	vmmc-supply = <&reg_dldo4>;
> > +	vqmmc-supply = <&reg_eldo1>;
> > +	mmc-pwrseq = <&wifi_pwrseq>;
> > +	non-removable;
> > +	bus-width = <4>;
> > +	status = "okay";
> > +};
> 
> As you mention above, Wi-Fi is a module, so may be absent. Is it really
> correct to enable this node and hardcode a certain power sequence? In
> theory other modules could be attached.
> 
> To me that calls for an overlay instead.

Agreed.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 11/11] arm64: allwinner: a64: enable Wi-Fi for Pine64 Andreas Färber <afaerber@suse.de> - 2017-04-14 19:00 +0200
  Re: [PATCH v2 11/11] arm64: allwinner: a64: enable Wi-Fi for Pine64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-17 10:00 +0200

csiph-web