[RFC][PATCH 0/3] add EXTCON_CHG_USB_* cables to MSM USB phy

From	Damien Riegel <damien.riegel@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	[RFC][PATCH 0/3] add EXTCON_CHG_USB_* cables to MSM USB phy
Date	2017-04-14 20:50 +0200
Message-ID	<twes9-4Ay-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

This patchset adds a way for the MSM USB phy to notify a power supply
when the charging state changes. It achieves that using the extcon
subsystem.

The first patch makes sure msm_otg_notify_charger is called after the
charger attributes have been set.
The second one makes sure that function is called when unplugging a
"in-the-wall" charger.
The last one adds EXTCON_CHG_USB_* cables to the phy.


I send this patchset as RFC because it seems a bit peculiar to have
different drivers that generate the EXTCON_USB_* and EXTCON_CHG_USB_*
events, so I want to make sure to get things right.

As far as I can tell, all the drivers in the kernel that have USB
charger events also have the EXTCON_USB one. In this case, this patchset
would make things a bit different for the MSM phy:

       +----------+      +--------------+
       |   gpio   |      |     PMIC     |<-+
       +----------+      +--------------+  |
           |                    |          |
           `--------------------+          |  EXTCON_CHG_USB_*
                                |          |       events
                    EXTCON_USB  |          |
                      events    |          |
                               \|/         |
                         +--------------+  |
                         |   USB PHY    |--+
                         +--------------+
       
Text version: EXTCON_USB comes from a GPIO or a PMIC, that triggers a
notifier in the USB phy. That notifier will determine the new
EXTCON_CHG_USB_XXX state and the PMIC will be notified about it and
determine how much current it can use to charge a battery.

Please let me know if this is the correct way to go.
 

Damien Riegel (3):
  usb: phy: msm: notify charger after setting charger info
  usb: phy: msm: notify charger when power supply is unplugged
  usb: phy: msm: use extcon to notify charger

 drivers/usb/phy/phy-msm-usb.c | 47 ++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 44 insertions(+), 3 deletions(-)

-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 0/3] add EXTCON_CHG_USB_* cables to MSM USB phy Damien Riegel <damien.riegel@savoirfairelinux.com> - 2017-04-14 20:50 +0200
  [RFC][PATCH 1/3] usb: phy: msm: notify charger after setting charger info Damien Riegel <damien.riegel@savoirfairelinux.com> - 2017-04-14 20:50 +0200
  [RFC][PATCH 3/3] usb: phy: msm: use extcon to notify charger Damien Riegel <damien.riegel@savoirfairelinux.com> - 2017-04-14 20:50 +0200
  [RFC][PATCH 2/3] usb: phy: msm: notify charger when power supply is unplugged Damien Riegel <damien.riegel@savoirfairelinux.com> - 2017-04-14 20:50 +0200

csiph-web