Re: [PATCH 03/22] libiscsi: Make use of new the sg_map helper function

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/22] libiscsi: Make use of new the sg_map helper function
Date	2017-04-14 17:40 +0200
Message-ID	<twbui-2Mv-23@gated-at.bofh.it> (permalink)
References	<tvV69-P8-5@gated-at.bofh.it> <tvVfP-Tr-1@gated-at.bofh.it> <tw4VQ-7gB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 14/04/17 02:36 AM, Christoph Hellwig wrote:
> On Thu, Apr 13, 2017 at 04:05:16PM -0600, Logan Gunthorpe wrote:
>> Convert the kmap and kmap_atomic uses to the sg_map function. We now
>> store the flags for the kmap instead of a boolean to indicate
>> atomicitiy. We also propogate a possible kmap error down and create
>> a new ISCSI_TCP_INTERNAL_ERR error type for this.
> 
> Can you split out the new error handling into a separate prep patch
> which should go to the iscsi maintainers ASAP?
> 

Yes, I can do that. I'd just have thought they'd want to see the use
case for the new error before accepting a patch like that...

Logan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 03/22] libiscsi: Make use of new the sg_map helper function Logan Gunthorpe <logang@deltatee.com> - 2017-04-14 00:20 +0200
  Re: [PATCH 03/22] libiscsi: Make use of new the sg_map helper         function Christoph Hellwig <hch@lst.de> - 2017-04-14 10:40 +0200
    Re: [PATCH 03/22] libiscsi: Make use of new the sg_map helper  function Logan Gunthorpe <logang@deltatee.com> - 2017-04-14 17:40 +0200

csiph-web