Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623749

Re: [PATCH 1/7] PCI: export pcie_flr

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH 1/7] PCI: export pcie_flr
Date 2017-04-14 18:00 +0200
Message-ID <twbNE-2TD-15@gated-at.bofh.it> (permalink)
References <tvOo2-4nr-3@gated-at.bofh.it> <tvOo3-4nr-43@gated-at.bofh.it> <twayd-2cI-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> s/pcie_has_flr/pcie_has_flr()/

Ok.

> This performs an FLR (if supported) always, regardless of "probe".
> I think it should look something like this instead:
> 
>   if (pcie_has_flr(dev)) {
>     if (!probe)
>       pcie_flr(dev);
>     rc = 0;
>     goto done;
>   }

Indeed!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

export pcie_flr and remove copies of it in drivers Christoph Hellwig <hch@lst.de> - 2017-04-13 17:00 +0200
  [PATCH 7/7] liquidio: use pcie_flr instead of duplicating it Christoph Hellwig <hch@lst.de> - 2017-04-13 17:00 +0200
  [PATCH 1/7] PCI: export pcie_flr Christoph Hellwig <hch@lst.de> - 2017-04-13 17:00 +0200
    Re: [PATCH 1/7] PCI: export pcie_flr Bjorn Helgaas <helgaas@kernel.org> - 2017-04-14 16:40 +0200
      Re: [PATCH 1/7] PCI: export pcie_flr Christoph Hellwig <hch@lst.de> - 2017-04-14 18:00 +0200
  Re: export pcie_flr and remove copies of it in drivers Bjorn Helgaas <helgaas@kernel.org> - 2017-04-14 16:50 +0200
    Re: export pcie_flr and remove copies of it in drivers Bjorn Helgaas <bhelgaas@google.com> - 2017-04-14 17:00 +0200
      Re: export pcie_flr and remove copies of it in drivers Christoph Hellwig <hch@lst.de> - 2017-04-14 18:00 +0200
    Re: export pcie_flr and remove copies of it in drivers Christoph Hellwig <hch@lst.de> - 2017-04-14 18:00 +0200

csiph-web