Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624420

Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value if chip reports it as zero

Show all headers | View raw

Dear Greg,


On 2017-04-15 22:50, Greg KH wrote:
> On Sat, Apr 15, 2017 at 06:26:22PM +0300, Jarkko Sakkinen wrote:
>> From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
>> 
>> Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for
>> TPM access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 
>> 13.9)
>> no longer works.  The initialization proceeds fine until we get and
>> start using chip-reported timeouts - and the chip reports C and D
>> timeouts of zero.
>> 
>> It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic
>> means to override the chip returned timeouts") we had actually let
>> default timeout values remain in this case, so let's bring back this
>> behavior to make chips like Atmel 3203 work again.
>> 
>> Use a common code that was introduced by that commit so a warning is
>> printed in this case and /sys/class/tpm/tpm*/timeouts correctly says 
>> the
>> timeouts aren't chip-original.
>> 
>> Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM 
>> access")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> What is the git commit id for this patch in Linus's tree?

The git commit hash is 1d70fe9d9c3a4c627f9757cbba5d628687b121c1.


Kind regards,

Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[backport v4.9] tpm_tis: use default timeout value if chip reports it as zero Jarkko Sakkinen <jsakkine@jsakkine-mobl1> - 2017-04-15 17:30 +0200
  Re: [backport v4.9] tpm_tis: use default timeout value if chip  reports it as zero "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-04-15 18:10 +0200
    Re: [backport v4.9] tpm_tis: use default timeout value if chip  reports it as zero Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-04-19 17:20 +0200
  Re: [backport v4.9] tpm_tis: use default timeout value if chip  reports it as zero Greg KH <greg@kroah.com> - 2017-04-16 10:10 +0200
    Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value  if chip reports it as zero Paul Menzel <pmenzel@molgen.mpg.de> - 2017-04-16 21:20 +0200
      Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value  if chip reports it as zero Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-04-19 17:30 +0200
        Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value  if chip reports it as zero Greg KH <greg@kroah.com> - 2017-04-19 17:40 +0200
          Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value  if chip reports it as zero Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-04-23 14:20 +0200

csiph-web