[PATCH] net/ncsi: fix checksum validation in response packet

From	Cédric Le Goater <clg@kaod.org>
Newsgroups	linux.kernel
Subject	[PATCH] net/ncsi: fix checksum validation in response packet
Date	2017-04-14 15:50 +0200
Message-ID	<tw9LP-1Gq-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

htonl was used instead of ntohl. Surely a typo.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 net/ncsi/ncsi-rsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c
index 087db775b3dc..d375286b79f2 100644
--- a/net/ncsi/ncsi-rsp.c
+++ b/net/ncsi/ncsi-rsp.c
@@ -52,7 +52,7 @@ static int ncsi_validate_rsp_pkt(struct ncsi_request *nr,
 
 	checksum = ncsi_calculate_checksum((unsigned char *)h,
 					   sizeof(*h) + payload - 4);
-	if (*pchecksum != htonl(checksum))
+	if (*pchecksum != ntohl(checksum))
 		return -EINVAL;
 
 	return 0;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/ncsi: fix checksum validation in response packet Cédric Le Goater <clg@kaod.org> - 2017-04-14 15:50 +0200
  Re: [PATCH] net/ncsi: fix checksum validation in response packet David Miller <davem@davemloft.net> - 2017-04-17 19:40 +0200
    Re: [PATCH] net/ncsi: fix checksum validation in response packet Gavin Shan <gwshan@linux.vnet.ibm.com> - 2017-04-18 02:10 +0200
      Re: [PATCH] net/ncsi: fix checksum validation in response packet Cédric Le Goater <clg@kaod.org> - 2017-04-18 12:00 +0200

csiph-web