Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1623603

Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all
Date 2017-04-14 11:30 +0200
Message-ID <tw5Id-7LL-9@gated-at.bofh.it> (permalink)
References <tw5oS-7Fv-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Apr 14, 2017 at 11:04:21AM +0200, Vincent Legoll wrote:
> No need to get into the submenu to disable all ANDROID-related config entries

I don't understand this, what exactly do you mean?

> 
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
>  drivers/android/Kconfig | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> index a82fc02..c2b6c37 100644
> --- a/drivers/android/Kconfig
> +++ b/drivers/android/Kconfig
> @@ -1,15 +1,11 @@
> -menu "Android"
> -
> -config ANDROID
> +menuconfig ANDROID
>  	bool "Android Drivers"
>  	---help---
>  	  Enable support for various drivers needed on the Android platform
>  
> -if ANDROID
> -
>  config ANDROID_BINDER_IPC
>  	bool "Android Binder IPC Driver"
> -	depends on MMU
> +	depends on ANDROID && MMU
>  	default n
>  	---help---
>  	  Binder is used in Android for both communication between processes,
> @@ -43,7 +39,3 @@ config ANDROID_BINDER_IPC_32BIT
>  	  earlier).
>  
>  	  Note that enabling this will break newer Android user-space.
> -
> -endif # if ANDROID
> -
> -endmenu

There are other ANDROID config options in the kernel other than right
here, so having a "menu" is a bit odd, right?

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] Make ANDROID a menuconfig to ease disabling it all Vincent Legoll <vincent.legoll@gmail.com> - 2017-04-14 11:10 +0200
  Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all Greg KH <gregkh@linuxfoundation.org> - 2017-04-14 11:30 +0200
    Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all Vincent Legoll <vincent.legoll@gmail.com> - 2017-04-14 11:50 +0200
      Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all Greg KH <gregkh@linuxfoundation.org> - 2017-04-14 14:40 +0200
        Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all Vincent Legoll <vincent.legoll@gmail.com> - 2017-04-14 14:50 +0200

csiph-web