Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623555

Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular

Show all headers | View raw

On Wed, Apr 12, 2017 at 09:57:55PM -0400, Paul Gortmaker wrote:
> The Makefile / Kconfig currently controlling compilation of this code is:
> 
> clock/Makefile:obj-$(CONFIG_INTEL_ATOMISP)     += vlv2_plat_clock.o
> 
> atomisp/Kconfig:menuconfig INTEL_ATOMISP
> atomisp/Kconfig:        bool "Enable support to Intel MIPI camera drivers"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_init was already not in use by this driver, the init
> ordering remains unchanged with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: linux-media@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I'm pretty sure we want this code to be built as a module, so maybe a
Kconfig change would resolve the issue instead?

Alan, any thoughts?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-04-13 04:10 +0200
  Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly  non-modular Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-14 10:20 +0200
    Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-04-14 18:00 +0200
    Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly  non-modular Alan Cox <alan@linux.intel.com> - 2017-04-14 22:50 +0200

csiph-web