Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623520

Re: [PATCH v2] Input: ar1021-i2c - fix too long name in driver's device table

Show all headers | View raw

2017-04-14 1:32 GMT+02:00 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> The name field in structure i2c_device_id is 20 characters, and we expect
> it to be NULL-terminated, however we are trying to stuff it with 21 bytes
> and thus NULL-terminator is lost. This causes issues when one creates
> device with name "MICROCHIP_AR1021_I2C" as i2c core cuts off the last "C",
> and automatic module loading by alias does not work as result.
>
> The -I2C suffix in the device name is superfluous, we know what bus we are
> dealing with, so let's drop it. Also, no other driver uses capitals, and
> the manufacturer name is normally not included, except in very rare cases
> of incompatible name collisions.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116211
> Fixes: dd4cae8bf166 ("Input: Add Microchip AR1021 i2c touchscreen")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-By: Christian Gmeiner <christian.gmeiner@gmail.com>

greets
--
Christian Gmeiner, MSc

https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] Input: ar1021-i2c - fix too long name in driver's device  table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-04-14 01:40 +0200
  Re: [PATCH v2] Input: ar1021-i2c - fix too long name in driver's  device table Christian Gmeiner <christian.gmeiner@gmail.com> - 2017-04-14 07:40 +0200
  Re: [PATCH v2] Input: ar1021-i2c - fix too long name in driver's  device table Martin Kepplinger <martin.kepplinger@ginzinger.com> - 2017-04-14 09:30 +0200
  Re: [PATCH v2] Input: ar1021-i2c - fix too long name in driver's  device table Jean Delvare <jdelvare@suse.de> - 2017-04-15 08:50 +0200

csiph-web