Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic'

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic'
Date	2017-04-13 00:20 +0200
Message-ID	<tvyMh-2fe-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <tvxwS-15r-21@gated-at.bofh.it> <tvxwS-15r-19@gated-at.bofh.it> <tvxQe-1uj-21@gated-at.bofh.it> <tvxQe-1uj-19@gated-at.bofh.it> <tvyjf-1Lt-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 12, 2017 at 11:47:49PM +0200, Borislav Petkov wrote:
> so we need to think about something better to handle events down the
> whole chain. Maybe route events from the atomic path to the blocking
> path where the sleeping notifier callbacks can sleep as much as they
> want to...

... and it is midnight here so I could be talking crap but we probably
should really split the reporting "chain" into two:

1. atomic context which doesn't do any notifier wankery. We simply call
non-sleeping functions one after the other. And those should be fast and
not taking any locks.

For example, I'm thinking you want to decode the error and that's it. So
we can replace the notifier call in print_mce() with our atomic context
function.

Then:

2. move the notifier completely in process context, convert it to a
blocking one and connect there all the noodling stuff like EDAC, NFIT,
mcelog, EXTLOG, ... I.e., all the logging machinery.

Problem solved.

And here's where you come in and say, "Boris, you're talking crap.." :-)

Lemme sleep on it.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Thread

[RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Vishal Verma <vishal.l.verma@intel.com> - 2017-04-12 00:50 +0200
  Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-12 11:20 +0200
    Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Vishal Verma <vishal.l.verma@intel.com> - 2017-04-12 22:10 +0200
      Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-12 22:30 +0200
        Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking'  from 'atomic' "Verma, Vishal L" <vishal.l.verma@intel.com> - 2017-04-12 22:30 +0200
          Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Dan Williams <dan.j.williams@intel.com> - 2017-04-12 23:00 +0200
            Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Thomas Gleixner <tglx@linutronix.de> - 2017-04-12 23:20 +0200
              Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' "Luck, Tony" <tony.luck@intel.com> - 2017-04-12 23:20 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-12 23:50 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-13 00:20 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' "Luck, Tony" <tony.luck@intel.com> - 2017-04-13 00:30 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-13 00:30 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-13 13:40 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-13 14:20 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' "Luck, Tony" <tony.luck@intel.com> - 2017-04-18 18:30 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking'  from 'atomic' "Verma, Vishal L" <vishal.l.verma@intel.com> - 2017-04-21 23:50 +0200
          Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' "Luck, Tony" <tony.luck@intel.com> - 2017-04-12 23:00 +0200
          Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Borislav Petkov <bp@suse.de> - 2017-04-12 23:20 +0200
            Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' Thomas Gleixner <tglx@linutronix.de> - 2017-04-13 00:00 +0200
              Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-13 00:50 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-13 01:50 +0200
                Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from  'atomic' "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-13 16:40 +0200
  [tip:ras/urgent] x86/mce: Make the MCE notifier a blocking one tip-bot for Vishal Verma <tipbot@zytor.com> - 2017-04-18 22:30 +0200

csiph-web