Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1622303

Re: [RFC][PATCH] sched: Have do_idle() call __schedule() without enabling preemption

Show all headers | View raw

On Wed, Apr 12, 2017 at 10:41:24AM -0400, Steven Rostedt wrote:
> [ tl;dr; version ]
> 
> Peter, In order to have synchronize_rcu_tasks() work, the idle task can
> never be preempted. There's a very small window in
> schedule_preempt_disable() that enables preemption, and when this
> happens, it breaks synchronize_rcu_tasks() (see above email for
> details).
> 
> Is there any reason to enable preemption, or can we simply have idle
> call into schedule without ever allowing it to be preempted, as in my
> patch?

Dunno,.. this changelog should convince me, not make me do the work :-)

> Note, it is almost good enough to just change
> schedule_preempt_disable() to do the exact same thing, but there's one
> instance in kernel/locking/mutex.c that calls it in a non running state.

The point being that that must not happen because of
sched_submit_work(), which, for idle, should not matter.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH] sched: Have do_idle() call __schedule() without  enabling preemption Steven Rostedt <rostedt@goodmis.org> - 2017-04-12 04:50 +0200
  Re: [RFC][PATCH] sched: Have do_idle() call __schedule() without  enabling preemption Steven Rostedt <rostedt@goodmis.org> - 2017-04-12 16:50 +0200
    Re: [RFC][PATCH] sched: Have do_idle() call __schedule() without  enabling preemption Peter Zijlstra <peterz@infradead.org> - 2017-04-12 18:30 +0200
      Re: [RFC][PATCH] sched: Have do_idle() call __schedule() without  enabling preemption Steven Rostedt <rostedt@goodmis.org> - 2017-04-12 18:50 +0200

csiph-web