Re: [PATCH 5/6] regulator: anatop-regulator: make regulator-name using optionally

From	Dong Aisheng <dongas86@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] regulator: anatop-regulator: make regulator-name using optionally
Date	2017-04-12 17:40 +0200
Message-ID	<tvsxc-6br-11@gated-at.bofh.it> (permalink)
References	<tvaJX-3qG-9@gated-at.bofh.it> <tvaJY-3qG-17@gated-at.bofh.it> <tvaJY-3qG-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 11, 2017 at 09:38:18PM +0100, Mark Brown wrote:
> On Wed, Apr 12, 2017 at 09:58:46AM +0800, Dong Aisheng wrote:
> > rdesc->name/regulator-name is optional according to standard regulator
> > binding doc. Use it conditionally to avoid a kernel NULL point crash.
> 
> It is optional in the standard binding because it is used to override
> the name statically provided in the driver for the device.  Since the
> anatop regulator is completely dynamic (there's no static list of
> regulators in the device) it's mandatory for anatop regulators - you
> should improve the error handling instead to detect a missing name.

Got it. Will change in v2.
Thanks for the suggestion.

Regards
Dong Aisheng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] regulator: anatop-regulator: make regulator-name  using optionally Mark Brown <broonie@kernel.org> - 2017-04-11 22:40 +0200
  Re: [PATCH 5/6] regulator: anatop-regulator: make regulator-name  using optionally Dong Aisheng <dongas86@gmail.com> - 2017-04-12 17:40 +0200

csiph-web