Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1622260

Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

Show all headers | View raw

On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote:
> On Wed, Apr 12, 2017 at 09:58:47AM +0800, Dong Aisheng wrote:
> > Set the initial voltage selector for vddpcie in case it's disabled
> > by default.
> 
> Why is this the only anatop regulator which can have this problem and
> how do we know this is a good value?

Anatop regulator has no separate gate bit.
e.g.
00000 Power gated off
00001 Target core voltage = 0.725V
...
So it may have no valid default voltage in case it's disabled in
bootloader.
e.g. regulator_enable() may not work.

The default voltage 1.100v this patch sets is defined in reference
manual.

Regards
Dong Aisheng

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 6/6] regulator: anatop: set default voltage selector for  pcie Mark Brown <broonie@kernel.org> - 2017-04-11 22:50 +0200
  Re: [PATCH 6/6] regulator: anatop: set default voltage selector for  pcie Mark Brown <broonie@kernel.org> - 2017-04-12 17:50 +0200
    Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie Dong Aisheng <dongas86@gmail.com> - 2017-04-12 18:20 +0200
  Re: [PATCH 6/6] regulator: anatop: set default voltage selector for  pcie Dong Aisheng <dongas86@gmail.com> - 2017-04-12 17:50 +0200
    Re: [PATCH 6/6] regulator: anatop: set default voltage selector for  pcie Lucas Stach <l.stach@pengutronix.de> - 2017-04-12 18:20 +0200
      Re: [PATCH 6/6] regulator: anatop: set default voltage selector for  pcie Mark Brown <broonie@kernel.org> - 2017-04-12 18:20 +0200

csiph-web