Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1622151

Re: [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime

From David Sterba <dsterba@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime
Date 2017-04-12 15:50 +0200
Message-ID <tvqOK-554-11@gated-at.bofh.it> (permalink)
References <ttN33-6YE-3@gated-at.bofh.it> <ttN35-6YE-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Apr 07, 2017 at 05:57:05PM -0700, Deepa Dinamani wrote:
> btrfs_root_item maintains the ctime for root updates.
> This is not part of vfs_inode.
> 
> Since current_time() uses struct inode* as an argument
> as Linus suggested, this cannot be used to update root
> times unless, we modify the signature to use inode.
> 
> Since btrfs uses nanosecond time granularity, it can also
> use ktime_get_real_ts directly to obtain timestamp for
> the root. It is necessary to use the timespec time api
> here because the same btrfs_set_stack_timespec_*() apis
> are used for vfs inode times as well. These can be
> transitioned to using timespec64 when btrfs internally
> changes to use timespec64 as well.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Acked-by: David Sterba <dsterba@suse.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

I'm going to add the patch to my 4.12 queue and will let Andrew know.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime David Sterba <dsterba@suse.cz> - 2017-04-12 15:50 +0200

csiph-web