Groups > linux.kernel > #1622064

Re: [PATCH v2 03/17] buffer: use mapping_set_error instead of setting the flag

Path	csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod
From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 03/17] buffer: use mapping_set_error instead of setting the flag
Date	Wed, 12 Apr 2017 14:20:01 +0200
Message-ID	<tvppD-4l7-5@gated-at.bofh.it> (permalink)
References	<tvpfY-4hS-3@gated-at.bofh.it> <tvppD-4l7-7@gated-at.bofh.it>
X-Original-To	Jeff Layton <jlayton@redhat.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, jack@suse.cz, willy@infradead.org, neilb@suse.com, viro@zeniv.linux.org.uk
X-Original-Date	Wed, 12 Apr 2017 14:17:17 +0200
X-Original-Message-ID	<20170412121717.GC1289@quack2.suse.cz>
X-Original-References	<20170412120614.6111-1-jlayton@redhat.com> <20170412120614.6111-4-jlayton@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1622064

Show key headers only | View raw

On Wed 12-04-17 08:06:00, Jeff Layton wrote:
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 9196f2a270da..70638941066d 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -483,7 +483,7 @@ static void __remove_assoc_queue(struct buffer_head *bh)
>  	list_del_init(&bh->b_assoc_buffers);
>  	WARN_ON(!bh->b_assoc_map);
>  	if (buffer_write_io_error(bh))
> -		set_bit(AS_EIO, &bh->b_assoc_map->flags);
> +		mapping_set_error(bh->b_assoc_map, -EIO);
>  	bh->b_assoc_map = NULL;
>  }
>  
> -- 
> 2.9.3
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 03/17] buffer: use mapping_set_error instead of  setting the flag Jan Kara <jack@suse.cz> - 2017-04-12 14:20 +0200

csiph-web