Groups > linux.kernel > #1622057

Re: [PATCH v2 1/1] pwm: pca9685: fix gpio-only operation.

From	Sven Van Asbroeck <thesven73@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/1] pwm: pca9685: fix gpio-only operation.
Date	2017-04-12 14:10 +0200
Message-ID	<tvpfZ-4hS-43@gated-at.bofh.it> (permalink)
References	<tv9ux-2HL-3@gated-at.bofh.it> <tv9ux-2HL-9@gated-at.bofh.it> <tvmi6-2l1-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 12, 2017 at 4:53 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> Looks like going to the right direction.

Thanks, I appreciate your comments !

>> +static void pca9685_pwm_gpio_free(struct gpio_chip *gpio, unsigned int offset)
> Why did you move the function here?

Because I added code that disables the output when the user releases
(unexports) the pwm or gpio.

If the output is not disabled on release (unexport):
- the output will remain in its previous state (possibly ON)
- when the last output is unexported, SLEEP is set, and all outputs
   are disabled at the same time
- this is counter-intuitive behaviour.

Expect a v3 patch soon which addresses your feedback.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/1] pwm: pca9685: fix gpio-only operation. Sven Van Asbroeck <thesven73@gmail.com> - 2017-04-11 21:20 +0200
  [PATCH v2 1/1] pwm: pca9685: fix gpio-only operation. Sven Van Asbroeck <thesven73@gmail.com> - 2017-04-11 21:20 +0200
    Re: [PATCH v2 1/1] pwm: pca9685: fix gpio-only operation. Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-12 11:00 +0200
      Re: [PATCH v2 1/1] pwm: pca9685: fix gpio-only operation. Sven Van Asbroeck <thesven73@gmail.com> - 2017-04-12 14:10 +0200

csiph-web