Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1622052
| From | Jeff Layton <jlayton@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 02/17] mm: fix mapping_set_error call in me_pagecache_dirty |
| Date | 2017-04-12 14:10 +0200 |
| Message-ID | <tvpfY-4hS-25@gated-at.bofh.it> (permalink) |
| References | <tvpfY-4hS-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The error code should be negative. Since this ends up in the default case anyway, this is harmless, but it's less confusing to negate it. Also, later patches will require a negative error code here. Signed-off-by: Jeff Layton <jlayton@redhat.com> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com> --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 27f7210e7fab..4b56e53e5378 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -674,7 +674,7 @@ static int me_pagecache_dirty(struct page *p, unsigned long pfn) * the first EIO, but we're not worse than other parts * of the kernel. */ - mapping_set_error(mapping, EIO); + mapping_set_error(mapping, -EIO); } return me_pagecache_clean(p, pfn); -- 2.9.3
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v2 02/17] mm: fix mapping_set_error call in me_pagecache_dirty Jeff Layton <jlayton@redhat.com> - 2017-04-12 14:10 +0200 Re: [PATCH v2 02/17] mm: fix mapping_set_error call in me_pagecache_dirty Jan Kara <jack@suse.cz> - 2017-04-12 14:20 +0200 Re: [PATCH v2 02/17] mm: fix mapping_set_error call in me_pagecache_dirty Matthew Wilcox <willy@infradead.org> - 2017-04-12 16:30 +0200
csiph-web