Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1622094
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 08/18] arm: sun8i: orangepi-pc: Enable dwmac-sun8i |
| Date | 2017-04-12 14:40 +0200 |
| Message-ID | <tvpJ0-4rx-5@gated-at.bofh.it> (permalink) |
| References | <tvotz-3N9-3@gated-at.bofh.it> <tvoDg-3Qd-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi Corentin,
On Wed, Apr 12, 2017 at 01:13:50PM +0200, Corentin Labbe wrote:
> The dwmac-sun8i hardware is present on the Orange PI PC.
> It uses the internal PHY.
>
> This patch create the needed emac node.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
> index f148111..746c25a 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
> @@ -53,6 +53,7 @@
>
> aliases {
> serial0 = &uart0;
> + ethernet0 = &emac;
Sorry for not spotting this earlier...
This should be ordered by alphabetical order,
> };
>
> chosen {
> @@ -184,3 +185,10 @@
> /* USB VBUS is always on */
> status = "okay";
> };
> +
> +&emac {
> + phy-handle = <&int_mii_phy>;
> + phy-mode = "mii";
> + allwinner,leds-active-low;
> + status = "okay";
> +};
And the node here as well.
Almost all your other DT patches also have this issue, please fix it
in all of them.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 00/18] net-next: stmmac: add dwmac-sun8i ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-12 13:30 +0200
[PATCH v4 03/18] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-12 13:30 +0200
[PATCH v4 04/18] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-12 13:30 +0200
Re: [PATCH v4 04/18] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon Rob Herring <robh@kernel.org> - 2017-04-19 23:10 +0200
Re: [PATCH v4 04/18] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon André Przywara <andre.przywara@arm.com> - 2017-04-20 01:50 +0200
Re: [PATCH v4 04/18] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-20 09:00 +0200
[PATCH v4 08/18] arm: sun8i: orangepi-pc: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-12 13:30 +0200
Re: [PATCH v4 08/18] arm: sun8i: orangepi-pc: Enable dwmac-sun8i Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-12 14:40 +0200
[PATCH v4 02/18] net: stmmac: add optional setup function Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-12 13:30 +0200
csiph-web