Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions
Date	2017-04-12 08:30 +0200
Message-ID	<tvjWW-13J-19@gated-at.bofh.it> (permalink)
References	(2 earlier) <tn4Lo-4J7-27@gated-at.bofh.it> <tnPqX-3Kn-37@gated-at.bofh.it> <tnQQ3-4OP-65@gated-at.bofh.it> <tuFGa-8rl-19@gated-at.bofh.it> <tuNkm-56T-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/10/2017, 09:35 PM, Josh Poimboeuf wrote:
> The code should be in a mergeable state after each patch.  If only
> patches 1-3 were merged, the code would be in an inconsistent state,
> with some functions having confusing ENTRY/SYM_FUNC_END pairs.  That
> complicates git history and also makes it harder to review each patch.
> 
> It would be cleaner to separate things out.  First, convert ENTRY/END
> functions to use ENDPROC, which is a minor bug fix.  Then they can be
> converted to the new SYM_FUNC_START/END macros in a separate patch.

OTOH I don't think touching and reviewing the same place twice is what
actually maintainers would want to see. But as I wrote earlier, I can do
whatever is preferred -- therefore I am asking before I start reworking
the patches: maintainers, what do you prefer?

thanks,
-- 
js
suse labs

Thread

Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-10 21:40 +0200
  Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions Jiri Slaby <jslaby@suse.cz> - 2017-04-12 08:30 +0200
    Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions Ingo Molnar <mingo@kernel.org> - 2017-04-12 09:00 +0200

csiph-web