Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support

From	Jie Deng <Jie.Deng1@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support
Date	2017-04-12 07:20 +0200
Message-ID	<tviRb-rj-5@gated-at.bofh.it> (permalink)
References	<tuZbP-4s3-1@gated-at.bofh.it> <tv5hh-8ip-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017/4/11 22:47, David Miller wrote:

> From: Jie Deng <Jie.Deng1@synopsys.com>
> Date: Tue, 11 Apr 2017 16:14:04 +0800
>
>> It is necessary to provide ethtool support for displaying and
>> modifying parameters of dwc-xlgmac.
>>
>> Signed-off-by: Jie Deng <jiedeng@synopsys.com>
> I don't see why you cannot allow the statistics to be obtained when
> the device is not running.  Similarly for other ethtool calls that
> just fetch information stored in the software state of the driver.
>
> I think your ->begin() method is way too restrictive.
Yeah, begin() seems unreasonable here. I will remove it.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: dwc-xlgmac: add the initial ethtool support Jie Deng <Jie.Deng1@synopsys.com> - 2017-04-11 10:20 +0200
  Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool  support David Miller <davem@davemloft.net> - 2017-04-11 16:50 +0200
    Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support Jie Deng <Jie.Deng1@synopsys.com> - 2017-04-12 07:20 +0200

csiph-web