Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock

From	Pushkar Jambhlekar <pushkar.iit@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock
Date	2017-04-12 06:20 +0200
Message-ID	<tvhV7-8fa-3@gated-at.bofh.it> (permalink)
References	<tuWxj-2Jg-3@gated-at.bofh.it> <tv6Gl-QX-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks Dan!

On Tue, Apr 11, 2017 at 9:47 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, Apr 10, 2017 at 10:26 PM, Pushkar Jambhlekar
> <pushkar.iit@gmail.com> wrote:
>> dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation
>>
>> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
>> ---
>>  drivers/dax/dax.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
>> index 0d1ca24..fd9c4db 100644
>> --- a/drivers/dax/dax.c
>> +++ b/drivers/dax/dax.c
>> @@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
>>                 rc = __dax_dev_pud_fault(dax_dev, vmf);
>>                 break;
>>         default:
>> -               return VM_FAULT_FALLBACK;
>> +               rc = VM_FAULT_FALLBACK;
>>         }
>>         rcu_read_unlock();
>
> Thanks Pushkar, I'll apply this and combine with patch 2 as well.



-- 
Jambhlekar Pushkar Arun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drivers/dax: Avoiding potential deadlock Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-04-11 07:30 +0200
  [PATCH 2/2] drivers/dax: Changing RC value Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-04-11 07:30 +0200
    Re: [PATCH 2/2] drivers/dax: Changing RC value Andrew Morton <akpm@linux-foundation.org> - 2017-04-11 23:00 +0200
      Re: [PATCH 2/2] drivers/dax: Changing RC value Dan Williams <dan.j.williams@intel.com> - 2017-04-12 18:30 +0200
  Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock Dan Williams <dan.j.williams@intel.com> - 2017-04-11 18:20 +0200
    Re: [PATCH 1/2] drivers/dax: Avoiding potential deadlock Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-04-12 06:20 +0200

csiph-web