Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621648

Re: [PATCH] mm, numa: Fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa

From Andrew Morton <akpm@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mm, numa: Fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa
Date 2017-04-11 23:50 +0200
Message-ID <tvbPH-471-9@gated-at.bofh.it> (permalink)
References (3 earlier) <tuLVf-4hB-23@gated-at.bofh.it> <tuLVf-4hB-21@gated-at.bofh.it> <tuPFv-6Jn-1@gated-at.bofh.it> <tuXD4-3po-21@gated-at.bofh.it> <tuXD4-3po-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, 11 Apr 2017 08:35:02 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:

> >> I have Kirrill's
> >>
> >> thp-reduce-indentation-level-in-change_huge_pmd.patch
> >> thp-fix-madv_dontneed-vs-numa-balancing-race.patch
> >> mm-drop-unused-pmdp_huge_get_and_clear_notify.patch
> >> thp-fix-madv_dontneed-vs-madv_free-race.patch
> >> thp-fix-madv_dontneed-vs-madv_free-race-fix.patch
> >> thp-fix-madv_dontneed-vs-clear-soft-dirty-race.patch
> >>
> >> scheduled for 4.12-rc1.  It sounds like
> >> thp-fix-madv_dontneed-vs-madv_free-race.patch and
> >> thp-fix-madv_dontneed-vs-madv_free-race.patch need to be boosted to
> >> 4.11 and stable?
> > 
> > thp-fix-madv_dontneed-vs-numa-balancing-race.patch is the fix for
> > numa balancing problem reported in this thread.
> > 
> > mm-drop-unused-pmdp_huge_get_and_clear_notify.patch,
> > thp-fix-madv_dontneed-vs-madv_free-race.patch,
> > thp-fix-madv_dontneed-vs-madv_free-race-fix.patch, and
> > thp-fix-madv_dontneed-vs-clear-soft-dirty-race.patch
> > 
> > are the fixes for other potential race problems similar to this one.
> > 
> > I think it is better to have all these patches applied.
> 
> Yeah we should get all such fixes to stable IMHO (after review :). It's
> not the first time that a fix for MADV_DONTNEED turned out to also fix a
> race that involved "normal operation" with THP, without such syscalls.

The presence of thp-reduce-indentation-level-in-change_huge_pmd.patch
is a pain in the ass but I've decided to keep it rather than churning
all the patches at a late stage.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm, numa: Fix bad pmd by atomically check for  pmd_trans_huge when marking page tables prot_numa Mel Gorman <mgorman@techsingularity.net> - 2017-04-10 19:30 +0200
  Re: [PATCH] mm, numa: Fix bad pmd by atomically check for  pmd_trans_huge when marking page tables prot_numa Mel Gorman <mgorman@techsingularity.net> - 2017-04-10 20:10 +0200
    Re: [PATCH] mm, numa: Fix bad pmd by atomically check for  pmd_trans_huge when marking page tables prot_numa Andrew Morton <akpm@linux-foundation.org> - 2017-04-11 00:10 +0200
      Re: [PATCH] mm, numa: Fix bad pmd by atomically check for  pmd_trans_huge when marking page tables prot_numa Vlastimil Babka <vbabka@suse.cz> - 2017-04-11 08:40 +0200
        Re: [PATCH] mm, numa: Fix bad pmd by atomically check for  pmd_trans_huge when marking page tables prot_numa Andrew Morton <akpm@linux-foundation.org> - 2017-04-11 23:50 +0200
      Re: [PATCH] mm, numa: Fix bad pmd by atomically check for  pmd_trans_huge when marking page tables prot_numa Mel Gorman <mgorman@techsingularity.net> - 2017-04-11 10:30 +0200

csiph-web