Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623410

Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

Show all headers | View raw

Hi Guenter,

On Thu, Apr 13, 2017 at 2:03 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Apr 07, 2017 at 03:00:08PM -0700, Moritz Fischer wrote:
>> From: Moritz Fischer <mdf@kernel.org>
>>
>> The ChromeOS EC has mapped memory regions where things like temperature
>> sensors and fan speed are stored. Provide access to those from the
>> cros-ec mfd device.
>>
>
> Turns out struct cros_ec_device already provides a cmd_readmem callback,
> which is widely used by other drivers. Why don't you just use it ?

This is only actually set by the lpc version of the cros_ec. I2C and
SPI connected ECs
emulate it. I can most certainly hook it up in the (spi,i2c) drivers,
but the implementation
for SPI and I2C needs to live somewhere. drivers/platform/chrome/cros_ec_proto.c
seemed to be a good place.

Thanks for the feedback!

Moritz

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory Guenter Roeck <linux@roeck-us.net> - 2017-04-13 23:10 +0200
  Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory Moritz Fischer <moritz.fischer.private@gmail.com> - 2017-04-14 01:00 +0200
    Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory Guenter Roeck <linux@roeck-us.net> - 2017-04-14 05:00 +0200

csiph-web