Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1623357
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM |
| Date | 2017-04-13 23:20 +0200 |
| Message-ID | <tvUjL-fo-1@gated-at.bofh.it> (permalink) |
| References | <tvROV-6SF-5@gated-at.bofh.it> <tvROW-6SF-39@gated-at.bofh.it> <tvUjL-fo-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Peter,
On 04/13/2017 05:43 PM, Peter Rosin wrote:
> On 2017-04-13 20:28, Javier Martinez Canillas wrote:
[snip]
>>
>> eeprom@50 {
>> - compatible = "nxp,24c02";
>> + compatible = "nxp,24c02","atmel,24c02";
>> reg = <0x50>;
>> pagesize = <16>;
>> };
>>
>
> Sure, in principle. But not having a space after the commas is a real OCD
> trigger for me. My spine is rotating... :-)
>
Right, Geert already pointed out. It's something I missed in my sed script
so I got it wrong in all the DTS :(
I'll fix my script and send a v2.
> Anyway, with those whitespace fixes (and without them too, but please):
> Acked-by: Peter Rosin <peda@axentia.se>
>
Thanks for the review!
> Cheers,
> peda
>
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-13 20:40 +0200
Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-13 23:20 +0200
Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-13 23:30 +0200
Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-14 01:50 +0200
Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM Simon Horman <horms@verge.net.au> - 2017-04-14 02:00 +0200
csiph-web