Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623154

Re: [PATCH 2/3] rtmutex: deboost priority conditionally when rt-mutex unlock

Show all headers | View raw

On Thu, 13 Apr 2017 16:39:52 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Thu, Apr 13, 2017 at 10:02:53PM +0800, Alex Shi wrote:
> >  	/*
> > +	 * 'current' release this lock, so 'current' should be a higher prio
> > +	 * task than the next top waiter, unless the current prio was gotten
> > +	 * from this top waiter, iff so, we need to deboost 'current' after
> > +	 * the lock release.
> > +	 */
> > +	if (current->prio == waiter->prio)
> > +		deboost = true;  
> 
> This is wrong.

The comment is, especially that "iff". What if current and waiter
happen to have the same priority? Then it too doesn't need to be
deboosted.

But that said, we currently perform the deboost unconditionally. I
can't think of a case where current->prio != waiter->prio where we
should perform the deboost, because current->prio should always be <=
waiter->prio (where lower prio means higher priority). Maybe I'm missing
something.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] rtmutex: deboost priority conditionally when rt-mutex unlock Alex Shi <alex.shi@linaro.org> - 2017-04-13 16:10 +0200
  Re: [PATCH 2/3] rtmutex: deboost priority conditionally when  rt-mutex unlock Sebastian Siewior <bigeasy@linutronix.de> - 2017-04-13 16:30 +0200
  Re: [PATCH 2/3] rtmutex: deboost priority conditionally when  rt-mutex unlock Peter Zijlstra <peterz@infradead.org> - 2017-04-13 16:50 +0200
    Re: [PATCH 2/3] rtmutex: deboost priority conditionally when  rt-mutex unlock Steven Rostedt <rostedt@goodmis.org> - 2017-04-13 18:20 +0200
      Re: [PATCH 2/3] rtmutex: deboost priority conditionally when  rt-mutex unlock Peter Zijlstra <peterz@infradead.org> - 2017-04-13 18:30 +0200
        Re: [PATCH 2/3] rtmutex: deboost priority conditionally when  rt-mutex unlock Steven Rostedt <rostedt@goodmis.org> - 2017-04-13 18:50 +0200
          Re: [PATCH 2/3] rtmutex: deboost priority conditionally when  rt-mutex unlock Peter Zijlstra <peterz@infradead.org> - 2017-04-13 19:00 +0200

csiph-web