Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1622879

Re: [PATCH] block: bios with an offset are always gappy

From Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH] block: bios with an offset are always gappy
Date 2017-04-13 12:10 +0200
Message-ID <tvJRn-1sn-5@gated-at.bofh.it> (permalink)
References <tvHZf-89-13@gated-at.bofh.it> <tvJy2-14D-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Apr 13, 2017 at 11:48:35AM +0200, Christoph Hellwig wrote:
> On Thu, Apr 13, 2017 at 10:06:29AM +0200, Johannes Thumshirn wrote:
> > Doing a mkfs.btrfs on a (qemu emulated) PCIe NVMe causes a kernel panic
> > in nvme_setup_prps() because the dma_len will drop below zero but the
> > length not.
> 
> I think we should also turns this into a WARN_ON_ONCE + error return..
> 
> But do you have an exact btrfsprogs version and command line?  I do a lot
> of testing that involves mkfs.btrfs on nvme and haven't seen it..

Ah one detail I forgot: mkfs.xfs _does_ work. Haven't checked ext4 though.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] block: bios with an offset are always gappy Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-13 10:10 +0200
  Re: [PATCH] block: bios with an offset are always gappy Christoph Hellwig <hch@lst.de> - 2017-04-13 11:50 +0200
    Re: [PATCH] block: bios with an offset are always gappy Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-13 12:00 +0200
    Re: [PATCH] block: bios with an offset are always gappy Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-13 12:10 +0200
  Re: [PATCH] block: bios with an offset are always gappy Ming Lei <ming.lei@redhat.com> - 2017-04-13 12:10 +0200
    Re: [PATCH] block: bios with an offset are always gappy Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-13 12:20 +0200
    Re: [PATCH] block: bios with an offset are always gappy Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-13 14:00 +0200
      Re: [PATCH] block: bios with an offset are always gappy Ming Lei <ming.lei@redhat.com> - 2017-04-13 14:20 +0200
        Re: [PATCH] block: bios with an offset are always gappy Ming Lei <ming.lei@redhat.com> - 2017-04-13 15:50 +0200
      Re: [PATCH] block: bios with an offset are always gappy Ming Lei <ming.lei@redhat.com> - 2017-04-13 16:50 +0200
        Re: [PATCH] block: bios with an offset are always gappy Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-13 17:00 +0200
        Re: [PATCH] block: bios with an offset are always gappy Andreas Mohr <andi@lisas.de> - 2017-04-13 22:40 +0200
          Re: [PATCH] block: bios with an offset are always gappy Ming Lei <ming.lei@redhat.com> - 2017-04-14 03:20 +0200

csiph-web