Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1622819

Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

Show all headers | View raw

Hi Sean,

Mostly looks good, have few minor comments.

On 13 April 2017 at 12:35,  <sean.wang@mediatek.com> wrote:
> +static bool mtk_rng_wait_ready(struct hwrng *rng, bool wait)
> +{
> +       struct mtk_rng *priv = to_mtk_rng(rng);
> +       int ready;
> +
> +       ready = readl(priv->base + RNG_CTRL) & RNG_READY;
> +       if (!ready && wait)
> +               readl_poll_timeout_atomic(priv->base + RNG_CTRL, ready,
> +                                         ready & RNG_READY, USEC_POLL,
> +                                         TIMEOUT_POLL);
> +       return !!ready;
> +}

Use readl_poll_timeout_atomic's return value or -EIO instead of
!!ready. This will simplify mtk_rng_read.

> +static int mtk_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
> +{
> +       struct mtk_rng *priv = to_mtk_rng(rng);
> +       int retval = 0;
> +
> +       while (max >= sizeof(u32)) {
> +               if (!mtk_rng_wait_ready(rng, wait))
> +                       break;
> +
> +               *(u32 *)buf = readl(priv->base + RNG_DATA);
> +               retval += sizeof(u32);
> +               buf += sizeof(u32);
> +               max -= sizeof(u32);
> +       }
> +
> +       if (unlikely(wait && max))
> +               dev_warn(priv->dev, "timeout might be not properly set\n");

Is this really necessary? Better to choose proper timeout than
providing this warning message. In rare cases if the timeout could
occur due to some reason (may be a hardware fault) print appropriate
warning message.

> +       return retval || !wait ? retval : -EIO;
> +}

Set retavl to mtk_rng_wait_ready and return retval.

Regards,
Prasanna

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] hwrng: mtk: add support for hardware random generator on MT7623 SoC <sean.wang@mediatek.com> - 2017-04-13 09:10 +0200
  [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC <sean.wang@mediatek.com> - 2017-04-13 09:10 +0200
    Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator  on MT7623 SoC PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-04-13 10:40 +0200
      Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random  generator on MT7623 SoC Sean Wang <sean.wang@mediatek.com> - 2017-04-14 06:00 +0200
        Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator  on MT7623 SoC PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-04-14 07:00 +0200
    Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator  on MT7623 SoC Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-13 13:10 +0200
      Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random  generator on MT7623 SoC Sean Wang <sean.wang@mediatek.com> - 2017-04-14 05:40 +0200
  [PATCH 1/2] dt-bindings: hwrng: Add Mediatek hardware random generator bindings <sean.wang@mediatek.com> - 2017-04-13 09:10 +0200
    Re: [PATCH 1/2] dt-bindings: hwrng: Add Mediatek hardware random  generator bindings Rob Herring <robh@kernel.org> - 2017-04-19 23:30 +0200

csiph-web