Re: [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation.

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation.
Date	2017-04-13 10:20 +0200
Message-ID	<tvI8W-cb-9@gated-at.bofh.it> (permalink)
References	<tvsdQ-64C-19@gated-at.bofh.it> <tvsdQ-64C-21@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, Apr 12, 2017 at 11:15:59AM -0400, Sven Van Asbroeck wrote:
> +	pm_runtime_set_active(&client->dev);
> +	/* enable will put the chip into suspend, which is what we
> +	 * want as all outputs are disabled at this point
> +	 */

This comment should also be in the standard block comment format.

Other than that, the patch looks good to me.

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/1] pwm: pca9685: fix gpio-only operation. Sven Van Asbroeck <thesven73@gmail.com> - 2017-04-12 17:20 +0200
  [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation. Sven Van Asbroeck <thesven73@gmail.com> - 2017-04-12 17:20 +0200
    Re: [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation. Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-13 10:20 +0200

csiph-web