Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver

From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver
Date	2017-04-11 21:10 +0200
Message-ID	<tv9kR-2Ej-1@gated-at.bofh.it> (permalink)
References	<tuNkm-56T-7@gated-at.bofh.it> <tuNkm-56T-11@gated-at.bofh.it> <tv8RQ-2eB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 11, 2017 at 11:34 AM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 10, 2017 at 12:35:12PM -0700, John Stultz wrote:
>
>> This patch adds a few extra error returns in cases that
>> shouldn't happen, some style nits adding breaks to final
>> default cases in switch statements, and tweaks to use
>> devm_ variant of snd_soc_register_component.
>
> Please don't make multiple unrelated changes in a single patch, it's bad
> practice which can slow down the bits of the patch which are OK and
> makes it harder to review if the changes match up with the changelog.

Apologies, I'll split it up and resend.

>>  static int hi6210_i2s_remove(struct platform_device *pdev)
>>  {
>>         snd_soc_unregister_component(&pdev->dev);
>
> Since you converted to devm_ this is now going to be a double free.

Ah. So it looks like can yank the whole remove implementation.

thanks
-john

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ASoC: Improve hi6210-i2s DT bindings John Stultz <john.stultz@linaro.org> - 2017-04-10 21:40 +0200
  [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver John Stultz <john.stultz@linaro.org> - 2017-04-10 21:40 +0200
    Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio  driver Mark Brown <broonie@kernel.org> - 2017-04-11 20:40 +0200
      Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver John Stultz <john.stultz@linaro.org> - 2017-04-11 21:10 +0200

csiph-web