Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621556

Re: [PATCH] livepatch: Cancel transition a safe way for immediate patches

Show all headers | View raw

On Tue, 11 Apr 2017, Petr Mladek wrote:

> klp_init_transition() does not set func->transition for immediate patches.
> Then klp_ftrace_handler() could use the new code immediately. As a result,
> it is not safe to put the livepatch module in klp_cancel_transition().
> 
> This patch reverts most of the last minute changes klp_cancel_transition().
> It keeps the warning about a misuse because it still makes sense.
> 
> Signed-off-by: Petr Mladek <pmladek@suse.com>
> ---
> Hi,
> 
> I am afraid that Mirek was not right in the mail
> https://lkml.kernel.org/r/alpine.LSU.2.20.1702161504020.16310@pobox.suse.cz
> IMHO, it is not safe to put the module when the immediate
> patch cannot be applied.

That's a very good catch indeed, thanks. Applied.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] livepatch: Cancel transition a safe way for immediate patches Petr Mladek <pmladek@suse.com> - 2017-04-11 13:10 +0200
  Re: [PATCH] livepatch: Cancel transition a safe way for immediate  patches Miroslav Benes <mbenes@suse.cz> - 2017-04-11 13:40 +0200
  Re: [PATCH] livepatch: Cancel transition a safe way for immediate  patches Josh Poimboeuf <jpoimboe@redhat.com> - 2017-04-11 17:20 +0200
  Re: [PATCH] livepatch: Cancel transition a safe way for immediate  patches Jiri Kosina <jikos@kernel.org> - 2017-04-11 21:00 +0200

csiph-web