Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1621509

[PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant

From Matthias Kaehlcke <mka@chromium.org>
Newsgroups linux.kernel
Subject [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant
Date 2017-04-11 20:00 +0200
Message-ID <tv8f8-1JB-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


A 64-bit value is not needed since a PCI ROM address consists in 32 bits.
This fixes a clang warning about "implicit conversion from 'unsigned
long' to 'u32'".

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- Define PCI_ROM_ADDRESS_MASK as a 32-bit constant instead of using a cast
- Updated commit message

 include/uapi/linux/pci_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 634c9c44ed6c..fff521c9458c 100644
--- a/include/uapi/linux/pci_regs.h
+++ b/include/uapi/linux/pci_regs.h
@@ -114,7 +114,7 @@
 #define PCI_SUBSYSTEM_ID	0x2e
 #define PCI_ROM_ADDRESS		0x30	/* Bits 31..11 are address, 10..1 reserved */
 #define  PCI_ROM_ADDRESS_ENABLE	0x01
-#define PCI_ROM_ADDRESS_MASK	(~0x7ffUL)
+#define PCI_ROM_ADDRESS_MASK	(~0x7ffU)
 
 #define PCI_CAPABILITY_LIST	0x34	/* Offset of first capability list entry */
 
-- 
2.12.2.715.g7642488e1d-goog

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant Matthias Kaehlcke <mka@chromium.org> - 2017-04-11 20:00 +0200
  Re: [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant Bjorn Helgaas <helgaas@kernel.org> - 2017-04-14 17:50 +0200
    Re: [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant Matthias Kaehlcke <mka@chromium.org> - 2017-04-14 21:40 +0200

csiph-web