Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621534
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] tty-goldfish: Use kcalloc() in goldfish_tty_create_driver() |
| Date | 2017-04-11 20:30 +0200 |
| Message-ID | <tv8Ia-2bb-21@gated-at.bofh.it> (permalink) |
| References | <tv8Ia-2bb-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 11 Apr 2017 20:00:23 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kcalloc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/tty/goldfish.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index 996bd473dd03..b92c3312ecd2 100644
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -180,8 +180,8 @@ static int goldfish_tty_create_driver(void)
int ret;
struct tty_driver *tty;
- goldfish_ttys = kzalloc(sizeof(*goldfish_ttys) *
- goldfish_tty_line_count, GFP_KERNEL);
+ goldfish_ttys = kcalloc(goldfish_tty_line_count, sizeof(*goldfish_ttys),
+ GFP_KERNEL);
if (goldfish_ttys == NULL) {
ret = -ENOMEM;
goto err_alloc_goldfish_ttys_failed;
--
2.12.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] TTY-goldfish: small adjustments for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-11 20:30 +0200 [PATCH 1/2] tty-goldfish: Use kcalloc() in goldfish_tty_create_driver() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-11 20:30 +0200 [PATCH 2/2] tty-goldfish: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-11 20:40 +0200
csiph-web