Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1621530

Re: [PATCH v6] kvm: better MWAIT emulation for guests

From Alexander Graf <agraf@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH v6] kvm: better MWAIT emulation for guests
Date 2017-04-11 20:30 +0200
Message-ID <tv8I9-2bb-5@gated-at.bofh.it> (permalink)
References <tv2t3-6q3-7@gated-at.bofh.it> <tv7Cp-1vq-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



> Am 11.04.2017 um 19:10 schrieb Jim Mattson <jmattson@google.com>:
> 
> This might be more useful if it could be dynamically toggled on and
> off, depending on system load.

What would trapping mwait (currently) buy you?

As it stands today, before this patch, mwait is simply implemented as a nop, so enabling the trap just means you're wasting as much cpu time, but never send the pCPU idle. With this patch, the CPU at least has the chance to go idle.

Keep in mind that this patch does *not* advertise the mwait cpuid feature bit to the guest.

What you're referring to I guess is actual mwait emulation. That is indeed more useful, but a bigger patch than this and needs some more thought on how to properly cache the monitor'ed pages.


Alex

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6] kvm: better MWAIT emulation for guests Alexander Graf <agraf@suse.de> - 2017-04-11 13:50 +0200
  Re: [PATCH v6] kvm: better MWAIT emulation for guests Alexander Graf <agraf@suse.de> - 2017-04-11 14:50 +0200
  Re: [PATCH v6] kvm: better MWAIT emulation for guests "Gabriel L. Somlo" <gsomlo@gmail.com> - 2017-04-11 14:50 +0200
    Re: [PATCH v6] kvm: better MWAIT emulation for guests "Gabriel L. Somlo" <gsomlo@gmail.com> - 2017-04-11 14:50 +0200
  Re: [PATCH v6] kvm: better MWAIT emulation for guests Jim Mattson <jmattson@google.com> - 2017-04-11 19:20 +0200
    Re: [PATCH v6] kvm: better MWAIT emulation for guests Alexander Graf <agraf@suse.de> - 2017-04-11 20:30 +0200
      Re: [PATCH v6] kvm: better MWAIT emulation for guests Jim Mattson <jmattson@google.com> - 2017-04-12 16:40 +0200
        Re: [PATCH v6] kvm: better MWAIT emulation for guests Alexander Graf <agraf@suse.de> - 2017-04-12 17:00 +0200
          Re: [PATCH v6] kvm: better MWAIT emulation for guests Jim Mattson <jmattson@google.com> - 2017-04-12 17:30 +0200
          Re: [PATCH v6] kvm: better MWAIT emulation for guests "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-12 18:30 +0200
            Re: [PATCH v6] kvm: better MWAIT emulation for guests Alexander Graf <agraf@suse.de> - 2017-04-21 12:10 +0200
              Re: [PATCH v6] kvm: better MWAIT emulation for guests Paolo Bonzini <pbonzini@redhat.com> - 2017-04-21 12:10 +0200
            Re: [PATCH v6] kvm: better MWAIT emulation for guests Paolo Bonzini <pbonzini@redhat.com> - 2017-04-21 12:10 +0200

csiph-web