Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable
Date	2017-04-11 18:00 +0200
Message-ID	<tv6n0-uP-7@gated-at.bofh.it> (permalink)
References	<toA6v-48t-37@gated-at.bofh.it> <tpNbj-7QT-3@gated-at.bofh.it> <tpP3r-Sl-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/27/2017 08:23 PM, Darren Hart wrote:
> On Tue, Mar 28, 2017 at 11:19:25AM +1100, Michael Ellerman wrote:
>> Darren Hart <dvhart@infradead.org> writes:
>>
>>> The use of $$OUTPUT in the target shell commands resulted in an empty
>>> string followed by an absolute path for which mkdir failed:
>>>
>>> $ make -C tools/testing/selftests/futex
>>> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
>>> Makefile:36: warning: overriding recipe for target 'clean'
>>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>> for DIR in functional; do		\
>>> 	BUILD_TARGET=$OUTPUT/$DIR;	\
>>> 	mkdir $BUILD_TARGET  -p;	\
>>> 	make OUTPUT=$BUILD_TARGET -C $DIR all;\
>>> done
>>> mkdir: cannot create directory ‘/functional’: Permission denied
>>>
>>> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
>>> variable. The above make command now completes successfully.
>>>
>>> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
>>> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
>>> Cc: linux-kselftest@vger.kernel.org
>>> Cc: bamvor.zhangjian@huawei.com
>>> Cc: Shuah Khan <shuah@kernel.org>
>>> Cc: <stable@vger.kernel.org> # 4.10.x-
>>
>> The OUTPUT support only went into v4.11-rc1, so I don't see why you need
>> a stable tag?
> 
> Git spelunking failure on my part, you are correct. Please disregard the stable
> tag.
> 
>>
>> Change looks good though.
>>
> 
> Thank you for the review.
> 

Thanks for fixing this.

Applied to linux-kselftest next after removing the stable tag.

-- Shuah

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-11 18:00 +0200

csiph-web