Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621252

Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()

Show all headers | View raw

On Tue, Apr 11, 2017 at 02:45:43PM +0200, Juergen Gross wrote:
> On 03/04/17 14:42, Daniel Kiper wrote:
> > On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote:
> >> For kdump to work correctly it needs the physical address of
> >> vmcoreinfo_note. When running as dom0 this means the virtual address
> >> has to be translated to the related machine address.
> >>
> >> paddr_vmcoreinfo_note() is meant to do the translation via
> >> __pa_symbol() only, but being attributed "weak" it can be replaced
> >> easily in Xen case.
> >>
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> >
> > Have you tested this patch with latest crash tool? Do dom0 and Xen
> > hypervisor analysis work without any issue (at least basic commands
> > like dmesg, bt, ps, etc.)? If yes for both you can add:
> >
> > Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> So can I add your R-b: now?

My R-b is still valid. Though, let's wait for Petr's Tested-by. He
did makedumpfile tests but I asked him to do crash tool tests too.
I think it is important.

Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Juergen Gross <jgross@suse.com> - 2017-04-11 14:50 +0200
  Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Daniel Kiper <daniel.kiper@oracle.com> - 2017-04-11 15:10 +0200
    Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Petr Tesarik <ptesarik@suse.com> - 2017-04-11 17:00 +0200
      Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Daniel Kiper <daniel.kiper@oracle.com> - 2017-04-11 19:30 +0200
        Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Petr Tesarik <ptesarik@suse.com> - 2017-04-14 19:00 +0200
          Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Daniel Kiper <daniel.kiper@oracle.com> - 2017-04-15 00:30 +0200
            Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Petr Tesarik <ptesarik@suse.com> - 2017-04-15 16:40 +0200

csiph-web