Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()

From	Petr Tesarik <ptesarik@suse.com>
Newsgroups	linux.kernel
Subject	Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()
Date	2017-04-11 13:00 +0200
Message-ID	<tv1GF-5TL-5@gated-at.bofh.it> (permalink)
References	<tsCCL-RD-45@gated-at.bofh.it> <tsR8K-1VT-17@gated-at.bofh.it> <ttydH-5d4-1@gated-at.bofh.it> <tuOzL-5Pa-17@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Mon, 10 Apr 2017 22:49:33 +0200
Daniel Kiper <daniel.kiper@oracle.com> wrote:

> On Fri, Apr 07, 2017 at 11:16:22AM +0200, Petr Tesarik wrote:
> > On Wed, 5 Apr 2017 13:13:00 +0200
> > Petr Tesarik <ptesarik@suse.com> wrote:
> >
> > > On Tue, 4 Apr 2017 12:42:53 -0700 (PDT)
> > > Daniel Kiper <daniel.kiper@oracle.com> wrote:
> > >
> > >[...]
> > > > So, if Petr did relevant tests that is nice. However, then, IMO, this
> > > > patch begs Petr Tested-by.
> > >
> > > Actually, I tested with this patch applied on top of kernel 4.4 (SLES
> > > 12 SP2). It matches what traditional Xen had always done, so I am quite
> > > confident it will work with a later kernel, but to give my Tested-by,
> > > let me first re-run the test on master, hopefully until today EOB.
> >
> > It took me much longer than anticipated (I had some trouble setting up
> > the host again), but I can confirm that the patch works as expected on
> 
> No problem. I know how it works.
> 
> > top of 4.11-rc5.
> 
> Great!
> 
> > Without the patch, makedumpfile in the crash kernel complains:
> >
> > /proc/vmcore doesn't contain vmcoreinfo.
> 
> Though, I would like to ask you to do crash tool tests too.
> Could you do that?

I'm not sure what kind of tests you want me to perform. I'm not able to
save a dump file without the patch.

Well ... I could reserve enough memory to launch a crash session
directly in the kdump environment. I'll get to you later.

> > With the patch applied, dumping still fails later because of an
> > unrelated bug in makedumpfile, but I was able to extract the kernel
> > message buffer with "makedumpfile --dump-dmesg". This already confirms
> > VMCOREINFO presence and usability.
> 
> Is it Xen specific issue or more generic one?

It is Xen-specific, and I even have a patch now, about to be sent to
the kexec ML.

Petr T

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Daniel Kiper <daniel.kiper@oracle.com> - 2017-04-10 23:00 +0200
  Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in  paddr_vmcoreinfo_note() Petr Tesarik <ptesarik@suse.com> - 2017-04-11 13:00 +0200

csiph-web