Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619600

[PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

mempool_alloc() cannot fail when passed GFP_NOIO or any
other gfp setting that is permitted to sleep.
So remove this pointless code.

Signed-off-by: NeilBrown <neilb@suse.com>
---
 drivers/scsi/ibmvscsi/ibmvfc.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 2c92dabb55f6..26cd3c28186a 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3910,12 +3910,6 @@ static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id)
 	spin_unlock_irqrestore(vhost->host->host_lock, flags);
 
 	tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);
-	if (!tgt) {
-		dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n",
-			scsi_id);
-		return -ENOMEM;
-	}
-
 	memset(tgt, 0, sizeof(*tgt));
 	tgt->scsi_id = scsi_id;
 	tgt->new_scsi_id = scsi_id;
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc() NeilBrown <neilb@suse.com> - 2017-04-10 04:20 +0200
  Re: [PATCH] scsi: ibmvfc: don't check for failure from  mempool_alloc() Tyrel Datwyler <turtle.in.the.kernel@gmail.com> - 2017-04-17 21:10 +0200
  Re: [PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc() "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-19 04:00 +0200

csiph-web