Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619553

[PATCH] phy: qcom-qmp: select COMMON_CLK

Show all headers | View raw

It is impossible to build Qualcom QMP phy driver without COMMON_CLK
enabled:
  CC      drivers/phy/phy-qcom-qmp.o
drivers/phy/phy-qcom-qmp.c: In function ‘phy_pipe_clk_register’:
drivers/phy/phy-qcom-qmp.c:932:9: error: variable ‘init’ has initializer
but incomplete type
  struct clk_init_data init = { };
         ^~~~~~~~~~~~~
drivers/phy/phy-qcom-qmp.c:932:23: error: storage size of ‘init’ isn’t
known
  struct clk_init_data init = { };
                       ^~~~
...

Selecting COMMON_CLK when PHY_QCOM_QMP is enabled fix this issue.

Fixes: 93a8c0c7b1ad ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index c120071fd2c8..e881eb2ef305 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -443,6 +443,7 @@ config PHY_QCOM_QMP
 	tristate "Qualcomm QMP PHY Driver"
 	depends on OF && (ARCH_QCOM || COMPILE_TEST)
 	select GENERIC_PHY
+	select COMMON_CLK
 	help
 	  Enable this to support the QMP PHY transceiver that is used
 	  with controllers such as PCIe, UFS, and USB on Qualcomm chips.
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] phy: qcom-qmp: select COMMON_CLK Jérémy Lefaure          <jeremy.lefaure@lse.epita.fr> - 2017-04-09 23:20 +0200
  Re: [PATCH] phy: qcom-qmp: select COMMON_CLK Kishon Vijay Abraham I <kishon@ti.com> - 2017-04-10 07:10 +0200

csiph-web